feat: Setup types for search data facets #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Removed vultr server and associated DNS entries |
jamdelion
approved these changes
Aug 27, 2024
editor.planx.uk/src/pages/FlowEditor/components/Sidebar/Search/facets.ts
Show resolved
Hide resolved
jessicamcinchak
approved these changes
Aug 28, 2024
editor.planx.uk/src/pages/FlowEditor/components/Sidebar/Search/facets.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Next steps...
As seen in the very rough #3476 there's a bit of a matrix of complexity here - we need to map each component type, for each data field, for 4 or 5 display fields.
The next PR will implement these types, likely pulling this logic out from nested conditional logic into an object or some data structure to hold this.