Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace craco with vite #3544

Merged
merged 13 commits into from
Aug 26, 2024
Merged

feat: Replace craco with vite #3544

merged 13 commits into from
Aug 26, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Aug 21, 2024 •
edited
Loading

What does this PR do?

  • Replaces craco with vite
  • Replaces jest with vitest

Motivations

  • create-react-app is pretty much deprecated, so it makes sense to look for alternatives
  • For a while now, we've been getting inconsistent issues when the app was being built that we've not been able to narrow down successfully. This branch originally started off as a test to see if a build using vite would resolve this - it seems to be the case that it does!

✅ Regression tests passing against branch here - https://github.com/theopensystemslab/planx-new/actions/runs/10560558494

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jessicamcinchak
Copy link
Member

Replace Jest with Vitest in Editor to fix CI build issues

@DafyddLlyr DafyddLlyr marked this pull request as ready for review August 26, 2024 12:15
@DafyddLlyr DafyddLlyr requested a review from a team August 26, 2024 12:18
@DafyddLlyr DafyddLlyr changed the title wip: Vite feat: Replace craco with vite Aug 26, 2024
jessicamcinchak
jessicamcinchak reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took another pass through all 100+ file changes with fresh eyes & a couple quick spots to tidy up before merge ! Thanks again for queuing up this big migration, feels good 🙌

editor.planx.uk/src/components/Header.test.tsx Outdated Show resolved Hide resolved
editor.planx.uk/src/lib/graphql.ts Outdated Show resolved Hide resolved
editor.planx.uk/src/testUtils.tsx Outdated Show resolved Hide resolved
editor.planx.uk/tsconfig.json Outdated Show resolved Hide resolved
DafyddLlyr
DafyddLlyr commented Aug 26, 2024
View reviewed changes
...planx.uk/src/pages/FlowEditor/components/Settings/tests/ServiceSettings/PublicLinks.test.tsx
@@ -121,7 +121,7 @@ describe("A team with a subdomain has an online, published service.", () => {

user.click(copyButton);

expect(await screen.findByText("copied")).toBeVisible();
expect((await screen.findAllByText("copied"))[0]).toBeVisible();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was throwing this error -
image

This looks like it was catching the tooltip as well as the actual text.

image

@DafyddLlyr DafyddLlyr merged commit ce05231 into main Aug 26, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/vite branch August 26, 2024 14:42
@DafyddLlyr DafyddLlyr mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak