Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace craco with vite #3544

Merged
merged 13 commits into from
Aug 26, 2024
Merged

feat: Replace craco with vite #3544

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0408963
wip
DafyddLlyr May 23, 2024
d6f8863
wip: Uncommemt axe tests, use vitest
DafyddLlyr Aug 21, 2024
35b02c3
feat: add `vitest-axe` & update frontend tests (#3549)
jessicamcinchak Aug 26, 2024
50372c6
chore: Remove /dist, populate /build
DafyddLlyr Aug 26, 2024
c712f92
test: Setup and manage Airbrake mocks and spies in vitest (#3558)
DafyddLlyr Aug 26, 2024
cac0464
Merge branch 'main' into dp/vite
DafyddLlyr Aug 26, 2024
f0c257d
test: Handle default export in `swr` (#3559)
DafyddLlyr Aug 26, 2024
095d5c9
test: Fix missed swr default test
DafyddLlyr Aug 26, 2024
45a4954
fix: PR feedback
DafyddLlyr Aug 26, 2024
f32e69c
chore: Tidy up tsconfig.json
DafyddLlyr Aug 26, 2024
dede76c
test: Cleanup testUtils
DafyddLlyr Aug 26, 2024
68b33df
test: Fix false positive for tooltip
DafyddLlyr Aug 26, 2024
ce4d8e6
ci: Update .env values in GitHub action
DafyddLlyr Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...nx.uk/src/pages/FlowEditor/components/Settings/tests/ServiceSettings/PublicLinks.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ describe("A team with a subdomain has an online, published service.", () => {

user.click(copyButton);

expect(await screen.findByText("copied")).toBeVisible();
expect((await screen.findAllByText("copied"))[0]).toBeVisible();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was throwing this error -
image

This looks like it was catching the tooltip as well as the actual text.

image

expect(navigator.clipboard.writeText).toBeCalledWith(
`https://${teamDomain}/${flowSlug}`,
);
Expand Down Expand Up @@ -232,7 +232,7 @@ describe("A team without a subdomain has an online, published service.", () => {

user.click(copyButton);

expect(await screen.findByText("copied")).toBeVisible();
expect((await screen.findAllByText("copied"))[0]).toBeVisible();
expect(navigator.clipboard.writeText).toBeCalledWith(publishedUrl);
});
});
Expand Down
Loading