fix(map-and-label): Add spacing between schema fields #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Aug 30, 2024
Comment on lines
+142
to
+146
| sx={(theme) => ({ | ||
| display: "flex", | ||
| flexDirection: "column", | ||
| gap: theme.spacing(2), | ||
| })} |
There was a problem hiding this comment.
This is the only change in this file, the rest is just linting (need to resolve this sooner rather than later!)
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Aug 30, 2024
| @@ -15,6 +17,7 @@ interface SchemaFieldsProps { | |||
| /** Formik instance generated from config provided by useSchema hook */ | |||
| formik: FormikProps<SchemaUserData>; | |||
| schema: Schema; | |||
| sx?: SxProps<Theme>; | |||
There was a problem hiding this comment.
super simple flexible solution 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Context
SchemaFieldsis intentionally unstyled - this should be left to the wrapping component (thoughts welcome!). By adding the MUIsxprop we allow a degree of flexibility here - unstyled out of the box, but a familiar API to actually configure this when needed.