feat: SummaryList view of Page component #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
|
I agree @DafyddLlyr, not ideal visually, and tricky as you say with the setup of injecting data into a pre-defined layout. However it does communicate the information in a way that is clear about the structure of the questions, and collapses to a single column correctly on smaller screens, so is more than adequate at this point. |
2 tasks
DafyddLlyr
changed the title
jessicamcinchak
approved these changes
Sep 17, 2024
editor.planx.uk/src/@planx/components/shared/Preview/SummaryList.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a view of the Page component inside SummaryList (Review component)
Would love some thoughts here @ianjon3s - very much not sold on this UI.
Breaking this out into its own
dlseems like the better solution here, but that would require a bit of a wider refactor due to how we're currently inserting components into cells. So I'm offering this up as a very rough version which at least handles getting the data to the right place, and to open up the discussion on the user interface