Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metabase token and base url placeholders to dotenv template #3815

Merged
merged 3 commits into from
Oct 16, 2024
Merged

feat: add metabase token and base url placeholders to dotenv template #3815

merged 3 commits into from
Oct 16, 2024

Conversation

zz-hh-aa
Copy link
Collaborator

  • Adds METABSE_API_KEY and METABASE_BASE_URL to api.planx.uk/.env.test.example template

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Pizza

Deployed 6f327ab to https://3815.planx.pizza.

Useful links:

DafyddLlyr
DafyddLlyr requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments!

  • I think we can group these within the # Metabase analytics section above
  • Can METABASE_BASE_URL can be set to METABASE_URL_EXT (which matches the API and Editor) and derived as METABASE_URL_EXT=http://localhost:${METABASE_PORT}
    • This is quite important as this value needs to change across local dev and pizzas (docker) and then on Pulumi (staging & production)
    • If you take a look at other references to API_URL_EXT you should see it has different formats in different environments

@zz-hh-aa
chore: move metabase tokens up file structure to root .env
6ffacbe 
also updates METABASE_BASE_URL to METABASE_URL_EXT
@zz-hh-aa
Copy link
Collaborator Author

Thanks @DafyddLlyr, I think I've made those changes, if I've understood you correctly?

DafyddLlyr
DafyddLlyr requested changes Oct 16, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
@zz-hh-aa
Copy link
Collaborator Author

Gotcha, now updated!

DafyddLlyr
DafyddLlyr approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - thanks for making those changes! 🙌

@zz-hh-aa zz-hh-aa merged commit 6e4a952 into main Oct 16, 2024
9 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/metabase-token-dotenv branch October 16, 2024 16:46
@zz-hh-aa zz-hh-aa mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zz-hh-aa @DafyddLlyr