Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump planx-core, update _address type in passport #3921

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 7, 2024

What does this PR do?

  • Updates planx-core (see chore: Update schema to v0.7.1 planx-core#557)
  • Update type for _address stored in passport to match schema - this should have a value of string | undefined and we're currently passing along ""
  • This is both correct from a type POV and falsy (in JS), but I think the intention here is not to populate the field so undefined seems correct here to me
Before After
image image

@DafyddLlyr DafyddLlyr changed the title dp/planx core 134b20d chore: Bump planx-core, update _address type in passport Nov 7, 2024
@DafyddLlyr DafyddLlyr force-pushed the dp/planx-core-134b20d branch from 5a6d054 to 1bb86e8 Compare November 7, 2024 15:35
Copy link

github-actions bot commented Nov 7, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit 280cfe0 into main Nov 7, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/planx-core-134b20d branch November 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants