Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tags to portals #3975

Merged
merged 5 commits into from
Nov 20, 2024
Merged

feat: add tags to portals #3975

merged 5 commits into from
Nov 20, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Nov 18, 2024

Following previous templates groundwork, this PR adds the ability to add tags to portals

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@RODO94 RODO94 marked this pull request as ready for review November 19, 2024 15:59
DafyddLlyr
DafyddLlyr approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

DafyddLlyr
DafyddLlyr requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just quickly checked the Pizza!

It would be good to sort the layout here -
image

I know these components aren't as well structured as others, but I think even just sorting out the margin here would be enough.

@RODO94
Copy link
Contributor Author

RODO94 commented Nov 19, 2024

Sorry just quickly checked the Pizza!

It would be good to sort the layout here - image

I know these components aren't as well structured as others, but I think even just sorting out the margin here would be enough.

Yes, good catch! I did stash these, I'll put up a fix now.

DafyddLlyr
DafyddLlyr reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes and visual output looking good! I think there's just some tests that need to be updated here and then we're good to go.

@RODO94
Copy link
Contributor Author

RODO94 commented Nov 20, 2024

Code changes and visual output looking good! I think there's just some tests that need to be updated here and then we're good to go.

Yeah, I did wonder why I stashed the UI changes... all good now

DafyddLlyr
DafyddLlyr approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - thanks for those changes!

@RODO94 RODO94 merged commit 912d1c3 into main Nov 20, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/tags-portals branch November 20, 2024 11:56
@RODO94
Copy link
Contributor Author

RODO94 commented Nov 20, 2024

Templates groundwork

@DafyddLlyr DafyddLlyr mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RODO94 @DafyddLlyr