feat: Add External Portals to E2E ui-driven tests #4005
Conversation
|
Removed vultr server and associated DNS entries |
RODO94
force-pushed
the
rory/e2e-ext-portals
branch
from
9ccf42f to
551aae8
Compare
There was a problem hiding this comment.
Some great comments here by @jamdelion 🙌
Great to see this being tested, a few comments to do with how context is handled - we should probably aim to keep this simple with a single flow if possible. Very open to thoughts here!
2 similar comments
RODO94
force-pushed
the
rory/e2e-ext-portals
branch
from
7f0d982 to
80bf6a1
Compare
separate out types and service data lint fix
RODO94
force-pushed
the
rory/e2e-ext-portals
branch
from
80bf6a1 to
eee94ee
Compare
| data?: object; | ||
| } | ||
|
|
||
| export interface TestContext { |
There was a problem hiding this comment.
nit: I'm not sure if TestContext is really much clearer or better than Context here when we're entirely within Playwright tests.
Not a strongly held opinion - was there a motivation for this change? Classes with BrowserContext maybe?
There was a problem hiding this comment.
I can't fully remember why, but it did come out of some frustration with the generalised context. Might have been to help express that as a Type it was generated within the Test so it is test specific, rather than bringing it in from external Types. If that makes sense?
What does this PR do?
This PR adds the External Portal component to the ui-driven end to end testing. This required adding another flow to the
create-flow.specso that it could be added properly and adjusting howflowsare handled incontext. If have separated out the flows so we haveflowwhich is intended to be the main one, thenexternalPortalFlowwhich is intended to only be for creating an External Portal. I foundmainFlow,targetFlow,parentFlowunnecessary and makingexternalPortalFlowfelt more explicit and easy to understand what it isI also set up some test fixes on flaky parts of the test and added helpers to simplify the process of publishing, turning a service online, and navigating between services.