ButtonLink: extended component as Link #184
Conversation
| variant={variant} | ||
| justifyContent="flex-start" | ||
| borderRadius="md" | ||
| textDecoration="none" |
There was a problem hiding this comment.
I added this style on the hover event to the Button theme.
There was a problem hiding this comment.
Previously when I commented on this line I didn't see any difference. I didn't see that the text was underlined. That's why I started to wonder if we need this. 🤔
There was a problem hiding this comment.
We need this because currently, we use Button as a Link component.
| ghost: { | ||
| _hover: { | ||
| bg: "transparent", | ||
| }, | ||
| _active: { | ||
| bg: "transparent", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Do we need it also? I don't see designs on Figma for a ghost button.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, I see it. But there is no such button in the styleguide. That's why I wonder if we need it. The task refers to the extension of the component ButtonLink as Link (extension of functionality). Therefore, it seems to me that at this PR we do not need to add it if it is not confirmed by Sorin.
There was a problem hiding this comment.
There are not many things that are stylized, but as we agreed - we style it based on the project. Let's leave it as is, if the design changes - we will change the style. I have the impression that we are discussing here matters that are of no great importance.
There was a problem hiding this comment.
If you understood it that way, I'm sorry. My question was just out of curiosity because I could not find such a variant in styleguide. I wasn't sure if the topic hadn't already been discussed with Sorin before and I missed something.
Yes, of course, we can update this later, it's not a problem. I just noticed that if it's not required in the task at all, we don't need to add it now and deal with it later when needed.
Closes: #180
Extended
buttonLinkcomponent to handling the href prop, eg. as Link component