-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style update for the connect button #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some thoughts.
dapp/src/theme/Button.ts
Outdated
@@ -6,8 +6,8 @@ import { | |||
// TODO: Update the button styles correctly when ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitively put this theme in order. 🙈 I have the impression that it is less and less clear.
36f0cf9
to
fc1ee5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good I have just a quick question. I'm not up to date with button styles. Correct me if I'm wrong. Shouldn't we use a variant card for this button as well?
acre/dapp/src/components/Overview/index.tsx
Lines 22 to 24 in 64a145b
<ButtonLink colorScheme="gold" bg="gold.200" onClick={onOpen}> | |
Docs | |
</ButtonLink> |
Nope, Docs has to have an outline variant, almost the same as in the sidebar. The card button has different styles in the guidelines (border, background, fontWeight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good. I have only one note that should not block this PR.
Nope, Docs has to have an outline variant, almost the same as in the sidebar. The card button has different styles in the guidelines (border, background, fontWeight)
Is it confirmed with Sorin? It would be good to clear it up how it should behave since we have changed the button styles so much. Make sure the whole thing is clickable or maybe just the text because that also changes our approach.
Because after checking the Figma it looks the same as the connect button (border, background).
The style guide should be our one source of truth, and here we have different styles for these buttons: But generally, I'll recheck and confirm this before merging. UPDATE: I asked @SorinQ about the |
Closes: #84
Adjusting design of the connect button to the newest guidelines buttons:
https://www.figma.com/file/OUdSfHsmgV8EJpWxAzXjl5/Design-Tasks?node-id=5297%3A46789&mode=dev