Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style update for the connect button #186

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Style update for the connect button #186

merged 3 commits into from
Feb 5, 2024

Conversation

ioay
Copy link
Contributor

@ioay ioay commented Jan 18, 2024

Closes: #84

Adjusting design of the connect button to the newest guidelines buttons:
https://www.figma.com/file/OUdSfHsmgV8EJpWxAzXjl5/Design-Tasks?node-id=5297%3A46789&mode=dev

@ioay ioay self-assigned this Jan 18, 2024
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some thoughts.

dapp/src/static/icons/Ethereum.tsx Outdated Show resolved Hide resolved
dapp/src/theme/Button.ts Show resolved Hide resolved
dapp/src/theme/Button.ts Outdated Show resolved Hide resolved
@ioay ioay requested a review from kkosiorowska January 23, 2024 13:29
dapp/src/theme/Button.ts Outdated Show resolved Hide resolved
@@ -6,8 +6,8 @@ import {
// TODO: Update the button styles correctly when ready
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitively put this theme in order. 🙈 I have the impression that it is less and less clear.

@ioay ioay marked this pull request as draft January 23, 2024 19:30
@ioay ioay force-pushed the 84-the-connect-button branch from 36f0cf9 to fc1ee5a Compare January 28, 2024 14:49
@ioay ioay requested a review from kkosiorowska January 28, 2024 14:50
@ioay ioay marked this pull request as ready for review January 28, 2024 14:50
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good I have just a quick question. I'm not up to date with button styles. Correct me if I'm wrong. Shouldn't we use a variant card for this button as well?

<ButtonLink colorScheme="gold" bg="gold.200" onClick={onOpen}>
Docs
</ButtonLink>

dapp/src/components/Header/ConnectWallet.tsx Outdated Show resolved Hide resolved
@ioay
Copy link
Contributor Author

ioay commented Jan 31, 2024

Overall it looks good I have just a quick question. I'm not up to date with button styles. Correct me if I'm wrong. Shouldn't we use a variant card for this button as well?

<ButtonLink colorScheme="gold" bg="gold.200" onClick={onOpen}>
Docs
</ButtonLink>

Nope, Docs has to have an outline variant, almost the same as in the sidebar. The card button has different styles in the guidelines (border, background, fontWeight)

@ioay ioay requested a review from kkosiorowska January 31, 2024 17:52
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. I have only one note that should not block this PR.

Nope, Docs has to have an outline variant, almost the same as in the sidebar. The card button has different styles in the guidelines (border, background, fontWeight)

Is it confirmed with Sorin? It would be good to clear it up how it should behave since we have changed the button styles so much. Make sure the whole thing is clickable or maybe just the text because that also changes our approach.

Because after checking the Figma it looks the same as the connect button (border, background).
Screenshot 2024-02-02 at 10 55 34

Screenshot 2024-02-02 at 10 55 48

@ioay
Copy link
Contributor Author

ioay commented Feb 5, 2024

Overall, it looks good. I have only one note that should not block this PR.

Nope, Docs has to have an outline variant, almost the same as in the sidebar. The card button has different styles in the guidelines (border, background, fontWeight)

Is it confirmed with Sorin? It would be good to clear it up how it should behave since we have changed the button styles so much. Make sure the whole thing is clickable or maybe just the text because that also changes our approach.

Because after checking the Figma it looks the same as the connect button (border, background). Screenshot 2024-02-02 at 10 55 34

Screenshot 2024-02-02 at 10 55 48

The style guide should be our one source of truth, and here we have different styles for these buttons:
Screenshot 2024-02-05 at 07 59 38
Screenshot 2024-02-05 at 07 59 54
Screenshot 2024-02-05 at 08 00 13

But generally, I'll recheck and confirm this before merging.

UPDATE: I asked @SorinQ about the Docs button. Let's merge it as it is at the moment, if a correction is required for Docs button, we will create a task for it, changes will not affect this task related to connected buttons.

@ioay ioay merged commit 8c0242a into main Feb 5, 2024
11 checks passed
@ioay ioay deleted the 84-the-connect-button branch February 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style update for the connect button
2 participants