Unification buttons link in dapp #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkosiorowska
requested changes
Jan 23, 2024
kkosiorowska
previously approved these changes
Jan 26, 2024
| import { USD } from "#/constants" | ||
| import PositionDetails from "./PositionDetails" | ||
| import Statistics from "./Statistics" | ||
| import TransactionHistory from "./TransactionHistory" | ||
| import ButtonLink from "../shared/ButtonLink" |
There was a problem hiding this comment.
Non-blocking comment
I just noticed that we are not using aliases here. However, the TextSm component is already imported from #/components/shared/Typography. When should we use aliases in this case? It would be good to standardize it in code.
There was a problem hiding this comment.
Yep, good catch, my IDE added imports automatically. Updated path for Typography. I think the IDE does it correctly and in case of child/parent nesting we should use a relative path.
kkosiorowska
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #177
Adjusting design of buttonLink to the newest guidelines buttons:
https://www.figma.com/file/OUdSfHsmgV8EJpWxAzXjl5/Design-Tasks?node-id=2394%3A25690&mode=dev