audio: remove all redundant list init's #5655
Conversation
comp_new() for both IPC3 and IPC4 initializes the source/sink buffer lists already. So, remove the redundant init from the component create callbacks. Signed-off-by: Ranjani Sridharan <[email protected]>
ranj063
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
|
oh man, that should have been caught by coverity. |
|
@kkarask will rerun CI again as the logs are timing out for 2 failed tests. |
|
SOFCI TEST |
|
@kkarask @wszypelt fwiw, looks like we have some test failures but the logs wont display. See https://sof-ci.01.org/sof-pr-viewer/#/build/PR5655/build9042903 |
|
@lgirdwood Yes, we have noticed that. In order to collect logs for IPC4 tests there is a need to change test code and adjust it to internal services. Work in progress. |
|
@kkarask ok, thanks - pls ping us when it's back working and we ca rerun this one (and any others) |
|
Can one of the admins verify this patch? |
|
SOFCI TEST |
|
@wszypelt the CI result is still not loading the logs for failed tests. Can you check ? Thanks ! |
|
@ranj063 ping |
| @@ -183,9 +183,6 @@ static struct comp_dev *create_host(struct comp_dev *parent_dev, struct copier_d | |||
| if (!dev) | |||
| return NULL; | |||
|
|
|||
| list_init(&dev->bsource_list); | |||
| list_init(&dev->bsink_list); | |||
|
|
|||
There was a problem hiding this comment.
are you sure this one and the one below are correct? create_host() and create_dai() call drv->ops.create() manually and .create() now doesn't initialise lists, so we initialise them here. create_host() and create_dai() are indeed called from a .new() method but that's creating a different device object.
|
No activity in a long time, converting as draft. |
comp_new() for both IPC3 and IPC4 initializes the source/sink buffer
lists already. So, remove the redundant init from the component create
callbacks.
Signed-off-by: Ranjani Sridharan [email protected]