Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: remove all redundant list init's #5655

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

audio: remove all redundant list init's #5655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/audio/aria/aria.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ static int init_aria(struct comp_dev *dev, struct comp_ipc_config *config,
int ret;

dev->ipc_config = *config;
list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

dcache_invalidate_region(spec, sizeof(*aria));
cd = rzalloc(SOF_MEM_ZONE_RUNTIME, 0, SOF_MEM_CAPS_RAM, sizeof(*cd));
Expand Down
9 changes: 0 additions & 9 deletions src/audio/copier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ static struct comp_dev *create_host(struct comp_dev *parent_dev, struct copier_d
if (!dev)
return NULL;

list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this one and the one below are correct? create_host() and create_dai() call drv->ops.create() manually and .create() now doesn't initialise lists, so we initialise them here. create_host() and create_dai() are indeed called from a .new() method but that's creating a different device object.

if (cd->direction == SOF_IPC_STREAM_PLAYBACK) {
comp_buffer_connect(dev, config->core, cd->endpoint_buffer,
PPL_CONN_DIR_COMP_TO_BUFFER);
Expand Down Expand Up @@ -278,9 +275,6 @@ static struct comp_dev *create_dai(struct comp_dev *parent_dev, struct copier_da

pipeline->sched_id = config->id;

list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

ret = comp_dai_config(dev, &dai, copier);
if (ret < 0)
return NULL;
Expand Down Expand Up @@ -355,9 +349,6 @@ static struct comp_dev *copier_new(const struct comp_driver *drv,
cd->out_fmt[0] = cd->config.out_fmt;
comp_set_drvdata(dev, cd);

list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

ipc_pipe = ipc_get_comp_by_ppl_id(ipc, COMP_TYPE_PIPELINE, config->pipeline_id);
if (!ipc_pipe) {
comp_cl_err(&comp_copier, "pipeline %d is not existed", config->pipeline_id);
Expand Down
2 changes: 0 additions & 2 deletions src/audio/up_down_mixer/up_down_mixer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,6 @@ static int init_up_down_mixer(struct comp_dev *dev, struct comp_ipc_config *conf
int ret;

dev->ipc_config = *config;
list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

dcache_invalidate_region(spec, sizeof(*up_down_mixer));
cd = rzalloc(SOF_MEM_ZONE_RUNTIME, 0, SOF_MEM_CAPS_RAM, sizeof(*cd));
Expand Down
2 changes: 0 additions & 2 deletions src/audio/volume/volume.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,6 @@ static struct comp_dev *volume_new(const struct comp_driver *drv,
return NULL;

dev->ipc_config = *config;
list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

cd = rzalloc(SOF_MEM_ZONE_RUNTIME, 0, SOF_MEM_CAPS_RAM,
sizeof(struct vol_data));
Expand Down
4 changes: 0 additions & 4 deletions src/ipc/ipc4/helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,6 @@ static struct comp_dev *ipc4_create_host(uint32_t pipeline_id, uint32_t id, uint
return NULL;

dev->direction = dir;
list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

return dev;
}
Expand Down Expand Up @@ -435,8 +433,6 @@ static struct comp_dev *ipc4_create_dai(struct pipeline *pipe, uint32_t id, uint
pipe->sched_id = id;

dev->direction = dir;
list_init(&dev->bsource_list);
list_init(&dev->bsink_list);

ret = comp_dai_config(dev, &dai, copier_cfg);
if (ret < 0)
Expand Down