-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torture): add sample-snapshot
option
#712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
This was referenced Jan 21, 2025
pepyakin
force-pushed
the
gm_torture_big_overflow_value_bug
branch
from
January 22, 2025 17:49
597a922
to
3a5180f
Compare
pepyakin
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
January 22, 2025 17:50
ee3ab28
to
4989d0f
Compare
gabriele-0201
force-pushed
the
gm_torture_big_overflow_value_bug
branch
from
January 23, 2025 09:05
3a5180f
to
0fd1f96
Compare
gabriele-0201
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
January 23, 2025 09:07
4989d0f
to
638fad3
Compare
pepyakin
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I don't think this should be configurable:
We should just limit the size of sample (and that in turn might be configurable). If the database fits into the limit, then great, we do exhaustive test. If it does not — then we sample.
rphmeier
changed the base branch from
gm_torture_big_overflow_value_bug
to
graphite-base/712
January 23, 2025 19:21
rphmeier
force-pushed
the
graphite-base/712
branch
from
January 23, 2025 19:23
0fd1f96
to
6bdc70b
Compare
rphmeier
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
January 23, 2025 19:23
638fad3
to
9d61919
Compare
rphmeier
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
January 23, 2025 19:23
9d61919
to
599b9b8
Compare
Together with `ensure-snapshot` they cover two different ways of checking the validity of the state after a crash or a rollback happened. `ensure-snapshot` checks the entire state while `sample-snapshot` just checks a random subset of the state.
gabriele-0201
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
January 24, 2025 10:01
599b9b8
to
49224a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with
ensure-snapshot
they cover two different ways ofchecking the validity of the state after a crash or a rollback happened.
ensure-snapshot
checks the entire state whilesample-snapshot
justchecks a random subset of the state.