Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torture): add sample-snapshot option #712

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

gabriele-0201
Copy link
Contributor

Together with ensure-snapshot they cover two different ways of
checking the validity of the state after a crash or a rollback happened.
ensure-snapshot checks the entire state while sample-snapshot just
checks a random subset of the state.

Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't think this should be configurable:

We should just limit the size of sample (and that in turn might be configurable). If the database fits into the limit, then great, we do exhaustive test. If it does not — then we sample.

torture/src/supervisor/workload.rs Outdated Show resolved Hide resolved
@rphmeier rphmeier changed the base branch from gm_torture_big_overflow_value_bug to graphite-base/712 January 23, 2025 19:21
@rphmeier rphmeier force-pushed the gm_torture_random_sample_entire_state branch from 638fad3 to 9d61919 Compare January 23, 2025 19:23
@rphmeier rphmeier changed the base branch from graphite-base/712 to master January 23, 2025 19:23
@rphmeier rphmeier force-pushed the gm_torture_random_sample_entire_state branch from 9d61919 to 599b9b8 Compare January 23, 2025 19:23
Together with `ensure-snapshot` they cover two different ways of
checking the validity of the state after a crash or a rollback happened.
`ensure-snapshot` checks the entire state while `sample-snapshot` just
checks a random subset of the state.
@gabriele-0201 gabriele-0201 force-pushed the gm_torture_random_sample_entire_state branch from 599b9b8 to 49224a2 Compare January 24, 2025 10:01
@gabriele-0201 gabriele-0201 merged commit 13599b6 into master Jan 24, 2025
8 checks passed
@gabriele-0201 gabriele-0201 deleted the gm_torture_random_sample_entire_state branch January 24, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants