fix(torture): move snapshot check #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
This was referenced Jan 21, 2025
pepyakin
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
ee3ab28 to
4989d0f
Compare
pepyakin
force-pushed
the
gm_torture_move_shanpshot_check
branch
from
865bd69 to
34cb3d1
Compare
gabriele-0201
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
4989d0f to
638fad3
Compare
gabriele-0201
force-pushed
the
gm_torture_move_shanpshot_check
branch
from
34cb3d1 to
13263ae
Compare
pepyakin
approved these changes
Jan 23, 2025
rphmeier
force-pushed
the
gm_torture_random_sample_entire_state
branch
2 times, most recently
from
9d61919 to
599b9b8
Compare
gabriele-0201
force-pushed
the
gm_torture_random_sample_entire_state
branch
from
599b9b8 to
49224a2
Compare
gabriele-0201
force-pushed
the
gm_torture_move_shanpshot_check
branch
from
13263ae to
0d9d2be
Compare
Base automatically changed from
gm_torture_random_sample_entire_state
to
master
January 24, 2025 11:47
Previously, the check was made immediately after respawning the child, which implied a check of the snapshot over a non-up-to-date `state.last_snapshot()`, leading to incorrect checks.
gabriele-0201
force-pushed
the
gm_torture_move_shanpshot_check
branch
from
0d9d2be to
5435408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check was made immediately after respawning the child,
which implied a check of the snapshot over a non-up-to-date
state.last_snapshot(), leading to incorrect checks.