Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5142.
Briefly, all scales ignore
AsIs
objects instead of invoking an identity scale.Contrary to my expectation, I only had to edit
ScalesList
methods (and their position equivalents) and no individual scales, so no deep rewrite was needed.While in #5142 I expressed worry about how position aesthetics would play with this, I've grown to love ignored position aesthetics. No more
annotation_custom()
or awkward manual transformations if you want to make relative annotations!Created on 2023-04-26 with reprex v2.0.2