-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring AsIs
objects (again)
#5477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Oct 12, 2023
This was referenced Oct 12, 2023
Closed
This comment was marked as resolved.
This comment was marked as resolved.
Can you update this for review? |
I've updated this PR with the latest suggestions |
thomasp85
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the 3rd attempt to fix #5142 and replaces #5290 and #5418.
Briefly, instead of assigning
scale_*_identity()
to<AsIs>
objects, it ignores these in scale operations.Benefits of this are:
aes(colour = I(...))
in one layers and doaes(colour = proper_column)
in another layer, without having a clash of colour scales.x/y = I(...)
effectively makes the position aesthetic in an relative unit ("npc"
units), which can be very convenient for annotations and such.The mechanism this PR employs is to hide/unhide
<AsIs>
column at strategic moments during plot building.'Ignoring' packs
<AsIs>
columns into one.ignored
data.frame column.'Exposing' unpacks the
.ignored
data.frame column into separate columns again.A quick comparison with the other PRs:
Compared to #5290:
<AsIs>
columns; plot building takes care of this.Compared to #5418:
<AsIs>
class is 'infective', the mechanism automatically propagates through reparameterization, which is desirable (e.g. from x/width to xmin/xmax).A quick benchmark to show that hiding/exposing scales well with dataset size (nrow = 32, 234 and 53.940 for mtcars, mpg and diamonds respectively). All in all, I think this PR wouldn't even add 1ms to plot building in 90% of plots.
Created on 2023-10-12 with reprex v2.0.2