Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace velodyne interpolate to distortion filter #1

Open
wants to merge 2 commits into
base: tier4/universe
Choose a base branch
from

Conversation

taichiH
Copy link
Contributor

@taichiH taichiH commented Nov 16, 2021

I replaced velodyne_interpolate_node to distortion_filter_node in common_sensor_launch/launch/velodyne_node_container.launch.py .

@yukkysaito
Copy link
Collaborator

ありがとうございます!一緒にvelodyne_vlsのinterporateの削除もお願いします

@yukkysaito yukkysaito marked this pull request as draft November 17, 2021 06:13
@yukkysaito
Copy link
Collaborator

@taichiH これどういう状態でしょう?

@taichiH
Copy link
Contributor Author

taichiH commented Nov 29, 2021

@yukkysaito DistortionCorrectorで動作確認した状況です。velodyne_vlsからinterporateは消していませんでした。

@taichiH taichiH marked this pull request as ready for review November 29, 2021 04:58
@yukkysaito
Copy link
Collaborator

yukkysaito commented Nov 29, 2021

@taichiH 了解です。velodyne_vlsは別リポになると思うのでこれはマージしましょう!

yukkysaito
yukkysaito previously approved these changes Nov 29, 2021
@taichiH
Copy link
Contributor Author

taichiH commented Nov 29, 2021

@yukkysaito すいません、aip_x1の方も変更します。

@yukkysaito
Copy link
Collaborator

(たしかに)

@yukkysaito
Copy link
Collaborator

(vls側は私の方で作業中です)

@taichiH
Copy link
Contributor Author

taichiH commented Nov 29, 2021

velodyne_vlsからinterpolate.ccを削除するPR
autowarefoundation/awf_velodyne#29

@kenji-miyake kenji-miyake changed the base branch from use-autoware-auto-msgs to tier4/universe January 31, 2022 13:23
@kenji-miyake kenji-miyake dismissed yukkysaito’s stale review January 31, 2022 13:23

The base branch was changed.

@satoshi-ota satoshi-ota removed their request for review August 25, 2022 00:49
joker-yt added a commit that referenced this pull request Sep 20, 2024
params for #1 or #2 based on v3.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants