-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace velodyne interpolate to distortion filter #1
Open
taichiH
wants to merge
2
commits into
tier4/universe
Choose a base branch
from
replace-velodyne-interpolate-to-distortion-correcctor
base: tier4/universe
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
replace velodyne interpolate to distortion filter #1
taichiH
wants to merge
2
commits into
tier4/universe
from
replace-velodyne-interpolate-to-distortion-correcctor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ありがとうございます!一緒にvelodyne_vlsのinterporateの削除もお願いします |
@taichiH これどういう状態でしょう? |
@yukkysaito DistortionCorrectorで動作確認した状況です。velodyne_vlsからinterporateは消していませんでした。 |
@taichiH 了解です。velodyne_vlsは別リポになると思うのでこれはマージしましょう! |
yukkysaito
previously approved these changes
Nov 29, 2021
@yukkysaito すいません、aip_x1の方も変更します。 |
(たしかに) |
(vls側は私の方で作業中です) |
velodyne_vlsからinterpolate.ccを削除するPR |
kenji-miyake
changed the base branch from
use-autoware-auto-msgs
to
tier4/universe
January 31, 2022 13:23
kenji-miyake
dismissed
yukkysaito’s stale review
January 31, 2022 13:23
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced
velodyne_interpolate_node
todistortion_filter_node
incommon_sensor_launch/launch/velodyne_node_container.launch.py
.