Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add imu_monitor and dummy diag #212

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat: add imu_monitor and dummy diag #212

merged 1 commit into from
Feb 16, 2024

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Feb 15, 2024 •
edited
Loading

Descriptions

imu_monitorおよびそのdummy diagを追加

Related Links

https://tier4.atlassian.net/browse/RT0-30650

Tests Performed

下記コマンドでautowareを起動し、

  • imu_monitorがros2 node listで存在している
  • rqt_runtime_monitorでdiagが存在している
    ことを確認した
$ ros2 launch autoware_launch autoware.launch.xml vehicle_model:=j6_gen1 sensor_model:=aip_x2 vehicle_id:=j6_gen1_01 map_path:=$HOME/map/X2/Shiojiri/ pointcloud_map_file:=pcd centerpoint_model_path:=$HOME/Downloads/centerpoint/ centerpoint_model_param_path:=$HOME/Downloads/centerpoint/aip_x2.param.yaml launch_vehicle:=false launch_system:=false launch_map:=false launch_sensing:=true launch_localization:=false launch_perception:=false launch_planning:=false launch_control:=false launch_v2x:=false launch_api:=false launch_l4_toolkit:=false

下記コマンドでplanning_simulatorを起動し、dumy diagが存在していることを確認した

$ ros2 launch autoware_launch planning_simulator.launch.xml vehicle_model:=j6_gen1 sensor_model:=aip_x2 vehicle_id:=j6_gen1_01 map_path:=$HOME/map/X2/Shiojiri/ pointcloud_map_file:=pcd launch_dummy_diag_publisher:=true

@h-ohta h-ohta requested a review from 0x126 February 15, 2024 07:30
0x126
0x126 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit 1e1313e into beta/x2/v3.0.0 Feb 16, 2024
12 of 13 checks passed
@h-ohta h-ohta deleted the feat/imu_monitor branch February 16, 2024 06:24
0x126 pushed a commit that referenced this pull request Jul 2, 2024
@h-ohta @0x126
feat: add imu_monitor and dummy diag (#212)
2c8c8fe
kotaro-hihara pushed a commit that referenced this pull request Aug 27, 2024
@h-ohta @kotaro-hihara
feat: add imu_monitor and dummy diag (#212)
c5348b5
kotaro-hihara added a commit that referenced this pull request Aug 27, 2024
@kotaro-hihara @TomohitoAndo
@pre-commit-ci @h-ohta
feat(aip_x2_launch): add topic state monitor for sensing diags (#288)
7aef84c 
* feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu (#227)

* feat: add topic state monitor for sensors

Signed-off-by: Tomohito Ando <[email protected]>

* fix comments

Signed-off-by: Tomohito Ando <[email protected]>

* replace launch.xml with launch.py

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

* add copyright

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* remove topic_state_monitor for camera

* feat: add imu_monitor and dummy diag (#212)

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <[email protected]>
TomohitoAndo added a commit that referenced this pull request Aug 30, 2024
@kotaro-hihara @TomohitoAndo
@pre-commit-ci @h-ohta
feat(aip_x2_launch): add topic state monitor for sensing diags (#288)
cfed45f 
* feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu (#227)

* feat: add topic state monitor for sensors

Signed-off-by: Tomohito Ando <[email protected]>

* fix comments

Signed-off-by: Tomohito Ando <[email protected]>

* replace launch.xml with launch.py

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

* add copyright

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* remove topic_state_monitor for camera

* feat: add imu_monitor and dummy diag (#212)

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x126 0x126 0x126 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-ohta @0x126