Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockage_diag): update param for aip_x2_launch #223

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 18, 2024

Description

Test Performed

@badai-nguyen badai-nguyen changed the title Refactor/blockage aip x2 chore(blockage_diag): update param for aip_x2_launch Mar 18, 2024
@kyoichi-sugahara
Copy link
Contributor

@badai-nguyen
thank you so much for separationg the PR.
I will review the PR later.
But basically this kind of change should be discussed with product team in my opinion.
If you agree with it, how about getting feedback from them?
This is just my beginner proposal and you can ignore if you think it's unnecesarry.
Let's discuss tomorrow

@badai-nguyen badai-nguyen requested a review from 0x126 March 18, 2024 23:22
@badai-nguyen
Copy link
Contributor Author

@badai-nguyen thank you so much for separationg the PR. I will review the PR later. But basically this kind of change should be discussed with product team in my opinion. If you agree with it, how about getting feedback from them? This is just my beginner proposal and you can ignore if you think it's unnecesarry. Let's discuss tomorrow

@kyoichi-sugahara
Thank you for your comment. As the updated description, please note that this PR is only to update the parameters for the releated refactor PR. There are no any change in performance of blockage diagnostics result.
cc @0x126 FYI.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@badai-nguyen badai-nguyen merged commit 73d85c5 into tier4:tier4/universe Mar 19, 2024
12 of 14 checks passed
badai-nguyen added a commit that referenced this pull request Mar 29, 2024
* chore: update blockage param for aip_x2_launch

Signed-off-by: badai-nguyen <[email protected]>

* chore: update param config

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
badai-nguyen added a commit that referenced this pull request Mar 29, 2024
* chore: update blockage param for aip_x2_launch

Signed-off-by: badai-nguyen <[email protected]>

* chore: update param config

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
0x126 pushed a commit that referenced this pull request Jul 2, 2024
* chore: update blockage param for aip_x2_launch

Signed-off-by: badai-nguyen <[email protected]>

* chore: update param config

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants