-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockage_diag): update param for aip_x2_launch #223
chore(blockage_diag): update param for aip_x2_launch #223
Conversation
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen |
@kyoichi-sugahara |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* chore: update blockage param for aip_x2_launch Signed-off-by: badai-nguyen <[email protected]> * chore: update param config Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
* chore: update blockage param for aip_x2_launch Signed-off-by: badai-nguyen <[email protected]> * chore: update param config Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
* chore: update blockage param for aip_x2_launch Signed-off-by: badai-nguyen <[email protected]> * chore: update param config Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
Description
blockage_diag
's params in aip_x2_launch package as some magic numbers were parameterized and individual LiDAR model was replaced by more general parameter at refactor PR: refactor(pointcloud_preprocessor): blockage_diag autowarefoundation/autoware.universe#5932Test Performed
Screencast from 2024年03月19日 00時10分20秒.webm