Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ground_segmentation): change parameter name #229

Merged
merged 2 commits into from
Apr 5, 2024
Merged

chore(ground_segmentation): change parameter name #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6bcfd7
chore(ground_segmentation): change parameter name
1222-takeshi Apr 4, 2024
1aa106d
ci(pre-commit): autofix
pre-commit-ci[bot] Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions aip_x1_1_launch/config/ground_segmentation/ground_segmentation.param.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@

common_crop_box_filter:
parameters:
min_x: -50.0
max_x: 100.0
min_y: -50.0
max_y: 50.0
max_z: 2.5
min_z: -0.5
min_x: -100.0
max_x: 150.0
min_y: -70.0
max_y: 70.0
margin_max_z: 0.0 # to extend the crop box max_z from vehicle_height
margin_min_z: -2.5 # to extend the crop box min_z from ground
negative: False

common_ground_filter:
Expand Down
2 changes: 2 additions & 0 deletions aip_x1_1_launch/launch/pandar_node_container.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def get_pandar_monitor_info():
p = yaml.safe_load(f)["/**"]["ros__parameters"]
return p


def get_vehicle_info(context):
# TODO(TIER IV): Use Parameter Substitution after we drop Galactic support
# https://github.com/ros2/launch_ros/blob/master/launch_ros/launch_ros/substitutions/parameter.py
Expand All @@ -56,6 +57,7 @@ def get_vehicle_info(context):
p["max_height_offset"] = gp["vehicle_height"]
return p


def launch_setup(context, *args, **kwargs):
def create_parameter_dict(*args):
result = {}
Expand Down
2 changes: 1 addition & 1 deletion aip_x1_1_launch/launch/pointcloud_preprocessor.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def launch_setup(context, *args, **kwargs):
name="concatenate_data",
remappings=[
("~/input/twist", "/sensing/vehicle_velocity_converter/twist_with_covariance"),
("output", "concatenated/pointcloud")
("output", "concatenated/pointcloud"),
],
parameters=[
{
Expand Down
2 changes: 1 addition & 1 deletion common_sensor_launch/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<exec_depend>dummy_diag_publisher</exec_depend>
<!-- <exec_depend>nebula_sensor_driver</exec_depend> -->
<exec_depend>radar_tracks_msgs_converter</exec_depend>
<exec_depend>radar_tracks_noise_filter</exec_depend>
<exec_depend>velodyne_monitor</exec_depend>
<!-- <exec_depend>nebula_sensor_driver</exec_depend> -->

<test_depend>ament_lint_auto</test_depend>
<test_depend>autoware_lint_common</test_depend>
Expand Down
Loading