Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aip_x1_launch): update compare_map_segmentation prefix #259

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jul 12, 2024

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen changed the title chore(aip_x1_launch): remove unneccessary depend chore(aip_x1_launch): update compare_map_segmentation prefix Jul 22, 2024
@badai-nguyen badai-nguyen marked this pull request as ready for review July 23, 2024 23:41
@badai-nguyen
Copy link
Contributor Author

@technolojin @tkimura4 Could I ask your review for this PR?

@badai-nguyen badai-nguyen enabled auto-merge (squash) July 24, 2024 00:39
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(However, is the exec_depend for compare_map_segmentation necessary? I think this line could be removed. )

@badai-nguyen badai-nguyen merged commit fd3cb5b into tier4:tier4/universe Jul 24, 2024
8 of 9 checks passed
@badai-nguyen
Copy link
Contributor Author

badai-nguyen commented Jul 24, 2024

I think this line could be removed.

@tkimura4 I'm sorry to enable auto-merge. You're right.
Firstly I was going to remove it but then keep it since x1 tends to use elevation_map_filter... I will create separate PR to remove that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants