Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(common_sensor_launch): revert PR of changing vlp16 param (#251) (#253) #281

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

zusizusi
Copy link
Contributor

@zusizusi zusizusi commented Aug 7, 2024

This reverts commit e536068.

This commit was added to fix the cycle drop issue.
The velodyne_hw_monitor that was causing the cycle drop problem has been temporarily reverted so this param will also be reverted.

@zusizusi zusizusi requested review from shmpwk, Ericpotato and drwnz August 7, 2024 10:07
@zusizusi zusizusi merged commit fe858c7 into beta/v0.29.0 Aug 7, 2024
9 of 10 checks passed
@zusizusi zusizusi deleted the tmp/revert-pr-253 branch August 7, 2024 11:35
1222-takeshi pushed a commit that referenced this pull request Aug 13, 2024
#253) (#281)

Revert "fix(common_sensor_launch): change vlp16 param (#251) (#253)"

This reverts commit e536068.

Signed-off-by: Sho Iwasawa <[email protected]>
TomohitoAndo pushed a commit that referenced this pull request Aug 30, 2024
#253) (#281)

Revert "fix(common_sensor_launch): change vlp16 param (#251) (#253)"

This reverts commit e536068.

Signed-off-by: Sho Iwasawa <[email protected]>
Autumn60 pushed a commit that referenced this pull request Sep 17, 2024
#253) (#281)

Revert "fix(common_sensor_launch): change vlp16 param (#251) (#253)"

This reverts commit e536068.

Signed-off-by: Sho Iwasawa <[email protected]>
Autumn60 pushed a commit that referenced this pull request Sep 17, 2024
#253) (#281)

Revert "fix(common_sensor_launch): change vlp16 param (#251) (#253)"

This reverts commit e536068.

Signed-off-by: Sho Iwasawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants