chore(nebula_node_container): fix, confirm and re-enable ring_outlier_filter #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the latest versions: nebula: develop-eval@81afef9ec1cdc1dae9d39e08e916813baab1fd4c transport_drivers: autowarefoundation/transport_drivers.git@8a93ae022604df8132bd65ab8a599532cf4c0a98 ros2_socketcan: /autowarefoundation/ros2_socketcan.git@2bbdba46ce4177e3076892aa99ede557b4f82446
|
@mojomex |
|
@TomohitoAndo Sorry, the wrong ref was pasted above. I edited it to point to the correct ref 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the
ring_outlier_filterinnebula_node_container.launch.pywhich was previously disabled in:The module is working (= outputting pointclouds at 10 Hz and not crashing) on my Desktop with one OT128 and one QT128 connected, with the current pilot-auto.x2.
Here are the versions used: