Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_x2_launch): add distortion corrector parameters #317

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Sep 18, 2024

distortion corrector node already remove the default parameters, thus aip_x2_launher also needs update

@vividf vividf requested a review from badai-nguyen September 18, 2024 08:05
@vividf vividf self-assigned this Sep 18, 2024
@vividf vividf changed the title feat: add parameter for aip_launcher_x2 feat(aip_x2_launch): add distortion corrector parameters Sep 18, 2024
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vividf vividf merged commit d0a6415 into tier4:tier4/universe Sep 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants