Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sync angle and cutting angle same as gen1 #323

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix: make sync angle and cutting angle same as gen1 #323

merged 3 commits into from
Oct 8, 2024

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Oct 2, 2024 •
edited
Loading

@TomohitoAndo TomohitoAndo changed the title Fix/sync angle cut angle fix: sync angle and cutting angle same as gen1 Oct 2, 2024
@TomohitoAndo TomohitoAndo changed the title fix: sync angle and cutting angle same as gen1 fix: make sync angle and cutting angle same as gen1 Oct 2, 2024
kotaro-hihara
kotaro-hihara approved these changes Oct 3, 2024
View reviewed changes
Copy link

@kotaro-hihara kotaro-hihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo
Copy link
Contributor Author

TomohitoAndo commented Oct 8, 2024 •
edited
Loading

Before this PR

Timestamp

image

Size of concatenate points

Min Max Average
13812096 14408320 14376881

image

Adter this PR

Timestamp

image

Size of concatenate points

Min Max Average
13936112 14386864 14373795

image

@TomohitoAndo TomohitoAndo merged commit 6104335 into beta/x2_gen2/v0.29.0 Oct 8, 2024
9 of 10 checks passed
@TomohitoAndo TomohitoAndo deleted the fix/sync-angle-cut-angle branch October 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotaro-hihara kotaro-hihara kotaro-hihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomohitoAndo @kotaro-hihara