Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aip_x2_gen2_launch): lidar distacne range #359

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kotaro-hihara
Copy link

LiDARごとに適切なmin_range, max_rangeになるよう修正
[slack](https://tier4.atlassian.net/browse/RT0-34722)

LSIMでconcat OK, perception機能することを確認
image

@TomohitoAndo
Copy link
Contributor

@kotaro-hihara
OTとQTのrange, 逆じゃないですか?
image

@kotaro-hihara kotaro-hihara force-pushed the fix/lidar_distacne_range branch from d83e843 to cb8c186 Compare December 13, 2024 08:13
@kotaro-hihara
Copy link
Author

@TomohitoAndo

OTとQTのrange, 逆じゃないですか?

逆でした 🙇  修正しました。
cb8c186

Copy link

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I did not have the time to do a launch check, but the code looks good 👍

@kotaro-hihara kotaro-hihara merged commit 77694d1 into beta/x2_gen2/v0.29.0 Dec 18, 2024
8 of 10 checks passed
@kotaro-hihara kotaro-hihara deleted the fix/lidar_distacne_range branch December 18, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants