forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): check path margin for overshoot vehicles on red light (#5394) #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomohitoAndo
requested review from
soblin,
shmpwk,
takayuki5168 and
tkimura4
as code owners
December 5, 2023 13:16
0x126
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saka1-s
added a commit
that referenced
this pull request
Mar 11, 2024
* feat(avoidance): keep stopping until all shift lines are registered Signed-off-by: satoshi-ota <[email protected]> * feat(map_loader): display curbstone as marker array (autowarefoundation#4958) display curbstone as marker array Signed-off-by: Shohei Sakai <[email protected]> Co-authored-by: kminoda <[email protected]> * revert refactoring due to cherry-pick * feat(ndt_scan_matcher): use glog (autowarefoundation#5465) (#1031) * feat(ndt_scan_matcher): use glog * style(pre-commit): autofix * update * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(out_of_lane): improve reuse of previous decision (#1017) * Do not directly reuse a prev stop point but project it on the new path Signed-off-by: Maxime CLEMENT <[email protected]> * Improve reuse of the previously inserted stop point Signed-off-by: Maxime CLEMENT <[email protected]> * Fix precision of inserted stop point Signed-off-by: Maxime CLEMENT <[email protected]> --------- Signed-off-by: Maxime CLEMENT <[email protected]> * fix(system_monitor): output command line (autowarefoundation#5430) (#1057) * fix(system_monitor): output command line * style(pre-commit): autofix --------- Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: pull tracking object merger from awf/main Signed-off-by: yoshiri <[email protected]> * feat(intersection): check path margin for overshoot vehicles on red light (autowarefoundation#5394) (#1056) Co-authored-by: Mamoru Sobue <[email protected]> * fix(ndt_scan_matcher): delete diagnostics thread (autowarefoundation#5532) Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO> * fix(ndt_scan_matcher): delete unmerged feature * fix(ndt_scan_matcher): fixed a lock scope in update_ndt (autowarefoundation#5951) Fixed the lock scope in update_ndt Signed-off-by: Shintaro SAKODA <[email protected]> * fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking (autowarefoundation#5842) (#1075) fix(utils): fix drivable area expansion logic for zebra zone Signed-off-by: satoshi-ota <[email protected]> * fix(bvp): traffic light state debug (#1083) Signed-off-by: Mehmet Dogru <[email protected]> * fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#5819) (#1124) * fix(traffic_light): stop if the traffic light signal timed out * fix(traffic_light): fix README format --------- Signed-off-by: Fumiya Watanabe <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> * refactor(mpc_lateral_controller): add debug info of qp solver (autowarefoundation#5459) (#1098) * add debug info of qp solver * no info for EigenLeastSquareLLT * return 0 in base class --------- Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: Shohei Sakai <[email protected]> Signed-off-by: kminoda <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Signed-off-by: yoshiri <[email protected]> Signed-off-by: yamato-ando <Yamato ANDO> Signed-off-by: Shintaro SAKODA <[email protected]> Signed-off-by: Mehmet Dogru <[email protected]> Signed-off-by: Fumiya Watanabe <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: satoshi-ota <[email protected]> Co-authored-by: kminoda <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <[email protected]> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: yoshiri <[email protected]> Co-authored-by: Mamoru Sobue <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Shinnosuke Hirakawa <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: Satoshi OTA <[email protected]> Co-authored-by: Mehmet Dogru <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporate improvement of intersection.
Related link
TIER IV INTERNAL
Tests performed
Tested on an actual vehicle.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.