Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane departure check,start planner): update lane departure check (cherry pick 8bdb5422c68 and 0042c2086d9) #1220

Merged

Conversation

danielsanchezaran
Copy link

@danielsanchezaran danielsanchezaran commented Apr 3, 2024

Description

(cherry pick 8bdb542 and 0042c20) to solve https://tier4.atlassian.net/browse/RT0-31009

Related links

Tests performed

Notes for reviewers

After this is merged, lane departure check should be enabled by default: https://github.com/tier4/autoware_launch.x2/pull/610/files

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

danielsanchezaran and others added 5 commits April 2, 2024 14:26
… lanes for bvspm (autowarefoundation#6366)

* WIP add new methods for lane departure checker

Signed-off-by: Daniel Sanchez <[email protected]>

* add lanelet polygon check for lane departure

Signed-off-by: Daniel Sanchez <[email protected]>

* use new checkPathWillLeaveLane function

Signed-off-by: Daniel Sanchez <[email protected]>

* working solution, fix union bug

Signed-off-by: Daniel Sanchez <[email protected]>

* Add check fo backwards path

Signed-off-by: Daniel Sanchez <[email protected]>

* delete departure check lanes

Signed-off-by: Daniel Sanchez <[email protected]>

* add lane departure check to geometric pullout

Signed-off-by: Daniel Sanchez <[email protected]>

* merge all union polygon

Signed-off-by: kyoichi-sugahara <[email protected]>

* pre-commit changes

Signed-off-by: Daniel Sanchez <[email protected]>

* move the cheap/fast check first to possibly boost performance

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: kyoichi-sugahara <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
…n#6588)

* fix union sometimes returning empty polygon

Signed-off-by: Daniel Sanchez <[email protected]>

* fix union of polygons

Signed-off-by: Daniel Sanchez <[email protected]>

* fix back launcher

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@TomohitoAndo TomohitoAndo merged commit afb0f60 into beta/v0.19.1 Apr 8, 2024
15 of 17 checks passed
@TomohitoAndo TomohitoAndo deleted the beta/v0.3.0.0-with-lane-departure-check-update branch April 8, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants