feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules v0.19.1 #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g turn signal for bpp modules (autowarefoundation#6625) add general method for calculating turn signal for bpp modules Signed-off-by: Daniel Sanchez <[email protected]>
…l method (autowarefoundation#6626) use the general calc turn signal method Signed-off-by: Daniel Sanchez <[email protected]>
…C module (autowarefoundation#6627) add general method to get turn signal for LC module Signed-off-by: Daniel Sanchez <[email protected]>
…utowarefoundation#6628) * Add general turnSignal method to start planner Signed-off-by: Daniel Sanchez <[email protected]> * add description to ignore signal Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
autowarefoundation#6629) add general turnsignalinfo method for goal planner Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
saka1-s
requested review from
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4,
rej55,
soblin,
maxime-clem,
TakaHoribe,
takayuki5168 and
zulfaqar-azmi-t4
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cherry-pick several PRs to improve the timing of turn signal.
Launcher PR: https://github.com/tier4/autoware_launch.x2/pull/662
feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules by danielsanchezaran · Pull Request #6625 · autowarefoundation/autoware.universe
feat(behavior_path_avoidance_module): use the general calc turn signal method by danielsanchezaran · Pull Request #6626 · autowarefoundation/autoware.universe
feat(lane_change_module): add general method to get turn signal for LC module by danielsanchezaran · Pull Request #6627 · autowarefoundation/autoware.universe
feat(start_planner): add general turn signal method to start planner by danielsanchezaran · Pull Request #6628 · autowarefoundation/autoware.universe
feat(goal_planner): add general turnsignalinfo method for goal planner by danielsanchezaran · Pull Request #6629 · autowarefoundation/autoware.universe
feat(behavior_path_planner_common,turn_signal_decider): add turn_signal_remaining_shift_length_threshold #7160
Tests performed
Tested on Psim.
Without PR
BeforePR.mp4
With PR
AfterPR.mp4
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.