Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): check lateral distance for previous output path shape change check #1326

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Jun 5, 2024

Description

https://star4.slack.com/archives/C074CCKN35E/p1717579630965109?thread_ts=1717491366.299959&cid=C074CCKN35E

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Author

kosuke55 commented Jun 5, 2024

main への PR
autowarefoundation#7283 差分あったのでx2はこのPRで対応予定

@mkuri mkuri marked this pull request as ready for review June 6, 2024 04:41
@mkuri mkuri self-requested a review June 6, 2024 04:43
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuri mkuri merged commit 08bf607 into beta/v0.19.1 Jun 17, 2024
13 of 14 checks passed
@mkuri mkuri deleted the fix/goal_planner_prev_shape_check_x2 branch June 17, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants