Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(motion_velocity_planner): resample trajectory and build rtree with packing algorithm #1361

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

maxime-clem
Copy link

@maxime-clem maxime-clem commented Jul 1, 2024

Description

Cherry-pick of autowarefoundation#7730 autowarefoundation#7732 autowarefoundation#7683 and autowarefoundation#7633

Tests performed

Psim and perception replayer.

Performance of the out_of_lane (most heavy module) on a rosbag with many dynamic objects:

  • Without the PR: ~50ms runtime with peaks at 80ms.
    image

  • With the PR: ~15ms runtime with peaks at 25ms
    image

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

autowarefoundation#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (autowarefoundation#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
Copy link

sonarcloud bot commented Jul 1, 2024

@takayuki5168 takayuki5168 merged commit a81d833 into beta/v0.29.0 Jul 1, 2024
25 of 26 checks passed
@takayuki5168 takayuki5168 deleted the cherry-pick/perf-out_of_lane branch July 1, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants