Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(euclidean_cluster): reduce false negative #815

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(euclidean_cluster): reduce false negative #815

merged 2 commits into from
Sep 11, 2023

Conversation

Shin-kyoto
Copy link

Description

  • We are experiencing issues with losing detection of front and side trucks, and this is resulting in unknown detection results. To resolve this problem, we will revert this PR and add the voxel_grid_downsample_filter.
  • We need to revert this PR as voxel_grid_downsample_filter won't function properly with it.

Related links

TIER IV INTERNAL LINK

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Shin-kyoto Shin-kyoto requested a review from tkimura4 September 10, 2023 22:50
@Shin-kyoto Shin-kyoto requested a review from Naophis September 10, 2023 23:35
Naophis
Naophis approved these changes Sep 11, 2023
View reviewed changes
Copy link

@Naophis Naophis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. check revert commit

@Naophis Naophis merged commit c606fec into tier4:beta/v0.10.0 Sep 11, 2023
10 checks passed
@Shin-kyoto Shin-kyoto deleted the fix/reduce_false_negative branch September 11, 2023 10:45
miursh added a commit that referenced this pull request Sep 15, 2023
@miursh
Revert "Merge pull request #815 from Shin-kyoto/fix/reduce_false_nega…
1fb1a6e 
…tive"

This reverts commit c606fec, reversing
changes made to bdccfb9.

# Conflicts:
#	launch/tier4_perception_launch/launch/object_recognition/detection/camera_lidar_fusion_based_detection.launch.xml
#	launch/tier4_perception_launch/launch/object_recognition/detection/camera_lidar_radar_fusion_based_detection.launch.xml
@miursh miursh mentioned this pull request Sep 15, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naophis Naophis Naophis approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@amc-nu amc-nu Awaiting requested review from amc-nu

@miursh miursh Awaiting requested review from miursh

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

Assignees
No one assigned
Labels
launch perception sensing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shin-kyoto @Naophis