Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add radar far detection pipeline #949

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Oct 16, 2023

Description

Radar遠距離出力を対応①

X2塩尻で田中さんが導入したdetectionベースのcamera_lidar_radar_fusionの実装PRになります。

事前に https://github.com/tier4/autoware_launch.xx1/pull/667 の変更が取り込まれていることを確認してください。

Merge radar far detection related PRs.

Related links

PRs in X2

Tests performed

デグレチェック:Predictionが正しく出るか確認

  • モード:camera_lidar_fusion

image

  • モード:camera_lidar_radar_fusion

image

検証環境

  • odaiba kadai 187のrosbagで検証
  • can_busがないのでradar_relay周りで少しアルゴリズム調整済

備考:

  • pointpaintingで大きなバスのYawが揺れることがある

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

scepter914 and others added 7 commits October 16, 2023 20:14
…ion for Camera-LiDAR-Radar fusion (autowarefoundation#5026)

* fix(tier4_perception_launch): add object_merger of far_objects to fusion for Camera-LiDAR-Radar fusion

Signed-off-by: scepter914 <[email protected]>

* fix conflict

Signed-off-by: scepter914 <[email protected]>

---------

Signed-off-by: scepter914 <[email protected]>
Signed-off-by: yoshiri <[email protected]>
…usion and fix launch order (autowarefoundation#5166)

* fix(tier4_perception_launch): add parameters for light weight radar fusion and fix launch order

Signed-off-by: scepter914 <[email protected]>

* style(pre-commit): autofix

* add far_object_merger_sync_queue_size param for package arg

Signed-off-by: scepter914 <[email protected]>

---------

Signed-off-by: scepter914 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…tion cost (autowarefoundation#5233)

* fix(tier4_perception_launch): fix node order in radar_based_detection.launch

Signed-off-by: scepter914 <[email protected]>

* fix comment out unused node

Signed-off-by: scepter914 <[email protected]>

---------

Signed-off-by: scepter914 <[email protected]>
@YoshiRi
Copy link
Author

YoshiRi commented Oct 16, 2023

動作確認済なのでmerge readyです

@tkimura4 tkimura4 merged commit 1174025 into tier4:beta/v0.10.3 Oct 17, 2023
32 checks passed
@YoshiRi YoshiRi deleted the chore/add_radar_pipeline branch October 30, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants