Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add sync-tier4-upstream-up-to-tag #347

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Mar 15, 2024

Description

現行のsync-tier4-upstreamでは、バージョン関係なくtier4/mainに対してsyncを実行してしまうためあるバージョンまでの変更を取り込みたい要望を満たすことが出来ない
そこで、指定したタグまでをsync出来るようにactionを実装した
workflow dispatchとして実行し、その際にsyncしたいバージョンを指定する形を採用した

Related links

https://tier4.atlassian.net/browse/RT0-30930

Tests performed

パーソナルリポジトリにて動作を確認した
https://github.com/h-ohta/autoware_launch/actions/runs/8291571585
h-ohta/autoware_launch#13

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from tkimura4 March 15, 2024 05:46
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you !!!

@tkimura4 tkimura4 merged commit 2838290 into tier4/main Mar 18, 2024
11 checks passed
@tkimura4 tkimura4 deleted the feat/sync-tags branch March 18, 2024 06:56
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Jul 5, 2024
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
shmpwk pushed a commit that referenced this pull request Jul 21, 2024
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants