-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v3.7.x): fix unexpected behavior related to available_ecu_ids #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodong-Yang
added a commit
to Bodong-Yang/ota-client
that referenced
this pull request
Apr 21, 2024
commit f73c6d0 Author: Bodong Yang <[email protected]> Date: Mon Apr 22 00:16:45 2024 +0900 fix(v3.7.x): not merging available_ecu_ids from child ECUs status resp again (tier4#290) This PR fixes an unexpected implementation details which prevents the available_ecu_ids for actually behaving as expected. This is caused by: * ota_client_stub module merges the available_ecu_ids from sub ECU's status response. * ecu_info parsing logic has an implicit implementation detail for backward compatibility, which when available_ecu_ids is not defined in the ecu_info.yaml, add this ECU id into this field. The above effectively disabling the functionality of available_ecu_ids, unless the corresponding ECU contacts that don't need OTA also being commented out in ecu_info.yaml. With this PR, now the available_ecu_ids field should work as expected, and the behavior aligns with the documentation, which only available_ecu_ids from the main ECU is respected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an unexpected implementation details which prevents the
available_ecu_ids
for actually behaving as expected.This is caused by:
ota_client_stub
module merges theavailable_ecu_ids
from sub ECU's status response.ecu_info
parsing logic has an implicit implementation detail for backward compatibility, which whenavailable_ecu_ids
is not defined in theecu_info.yaml
, add this ECU id into this field.The above effectively disabling the functionality of
available_ecu_ids
, unless the corresponding ECU contacts that don't need OTA also being commented out inecu_info.yaml
.With this PR, now the
available_ecu_ids
field should work as expected, and the behavior aligns with the documentation, which onlyavailable_ecu_ids
from the main ECU is respected.