Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v3.7.x): fix unexpected behavior related to available_ecu_ids #290

Merged
merged 1 commit into from
Apr 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions otaclient/app/ota_client_stub.py
Original file line number Diff line number Diff line change
Expand Up @@ -516,11 +516,6 @@ async def update_from_child_ecu(self, status_resp: wrapper.StatusResponse):
"""Update the ECU status storage with child ECU's status report(StatusResponse)."""
async with self._writer_lock:
self.storage_last_updated_timestamp = cur_timestamp = int(time.time())
_subecu_available_ecu_ids = _OrderedSet(status_resp.available_ecu_ids)
# discover further child ECUs from directly connected sub ECUs.
self._tracked_active_ecus.update(_subecu_available_ecu_ids)
# merge available_ecu_ids from child ECUs resp to include further child ECUs
self._available_ecu_ids.update(_subecu_available_ecu_ids)

# NOTE: use v2 if v2 is available, but explicitly support v1 format
# for backward-compatible with old otaclient
Expand Down
Loading