Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable sim_time trace point in light mode #152

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Nov 20, 2023

Description

When the "--light" option is specified in the caret trace command, sim_time is added to the trace points.

Related links

https://tier4.atlassian.net/browse/RT2-1083

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 changed the title feat: Enable sim_time trace point in light mode. feat: Enable sim-time trace point in light mode. Nov 20, 2023
@xygyo77 xygyo77 changed the title feat: Enable sim-time trace point in light mode. feat: Enable sim-time trace point in light mode Nov 20, 2023
@xygyo77 xygyo77 changed the title feat: Enable sim-time trace point in light mode feat: Enable simtime trace point in light mode Nov 20, 2023
@xygyo77 xygyo77 changed the title feat: Enable simtime trace point in light mode feat: Enable sim_time trace point in light mode Nov 20, 2023
@xygyo77 xygyo77 changed the title feat: Enable sim_time trace point in light mode feat: enable sim_time trace point in light mode Nov 20, 2023
@isp-uetsuki isp-uetsuki self-requested a review November 20, 2023 08:40
Copy link
Contributor

@isp-uetsuki isp-uetsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xygyo77 xygyo77 merged commit 023c0db into tier4:main Dec 12, 2023
11 of 18 checks passed
@xygyo77 xygyo77 deleted the feat/sim-time-enable-in-light-mode branch December 13, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants