-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ego slope #1103
Closed
Closed
Feature/ego slope #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
…_pose Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
# Conflicts: # simulation/simple_sensor_simulator/include/simple_sensor_simulator/vehicle_simulation/ego_entity_simulation.hpp # simulation/simple_sensor_simulator/src/simple_sensor_simulator.cpp # simulation/simple_sensor_simulator/src/vehicle_simulation/ego_entity_simulation.cpp # test_runner/scenario_test_runner/launch/scenario_test_runner.launch.py
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
…urve::getPose Signed-off-by: Kotaro Yoshimoto <[email protected]>
…istance conditions Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
…ditions Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
I close this because I cannot assign @hakuturu583 to reviewer in this pull-request. |
HansRobo
changed the title
Consider road slope in distance measurement and entity poses
Feature/ego slope
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
feature
New feature or request
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
consider_pose_by_road_slope
flag to switch functionNote: All the features can be toggled by
consider_pose_by_road_slope
and disabled defaultly to ensure backward-compatibility.Background
One of the characteristics of
scenario_simualtor_v2
is that it is a simple and lightweight simulator.Therefore, we have mainly dealt with simulations on a 2D plane without considering the Z direction or pitch/roll axes.
However, as the behavior on slopes is now being checked in autoware developing, simulation on a 2D plane alone is no longer able to cover the evaluation of Planning/Control, which is the main evaluation target of
scenario_simualtor_v2
.So, we started to support simulation on 3D pose.
Details
Note: I would like to thank @dmoszynski for his great efforts for this pull-request.
Entity pose pitch-fitting to HDMap
As long as lane matching is successful,
scenario_simulator_v2
tries to constrain the pose on the HDMap.Specifically, the situation is as follows.
AddEntityAction
TeleportAction
AcquirePositionAction
FollowTrajectoryAction
AssignRouteAction
The z fitting to HDMap was already performed in
scenario_simulator_v2
until now.But the entity pose fitting was not complete until now: pitch and roll angle were not fitted to HDMap.
In this pull-request, pitch-fitting is implemented.
With OpenSCENARIO
WorldPosition
/RelativeWorldPosition
/RelativeObjectPosition
,scenario_simulator_v2
will be performing both of z-fitting and pitch-fitting.With OpenSCENARIO
LanePosition
,scenario_simulator_v2
will be performing only pitch fitting.( Other position types are not supported in
scenario_simulator_v2
now )The pitch-fitting is also affected to bounding-box-based distance evaluation(freespace=true), because the orientation of entity bounding-box can be changed by pitch-fitting.
Distance evaluation
The euclidean distance evaluation in OpenSCENARIO
DistanceCondition
/RelativeDistanceCondition
/ReachPositionCondition
is performed in 2D plane previously.In this pull-request, I implemented 3D euclidean dintance evaluation.
References
INTERNAL INVESTIGATION LINK
Destructive Changes
There is no destructive changes because this function is disabled defaultly.
Known Limitations
No roll-fitting to HDMap
In this pull-request, orientation fitting is implemented for pitch angle only.
This is because it follows the implementation of
simple_planning_simulator
inautoware.universe
.No orientation-fitting to HDMap in
OccupancyGridSensor
The GridMap output from
scenario_simulator_v2
is always horizontal regardless of the road slope.This is because current implementation of autoware.universe does not consider the roll and pitch axes.