-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/speed condition #1469
Merged
Merged
Refactor/speed condition #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
yamacir-kit
added
refactor
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
labels
Dec 3, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…aluateSpeed` Signed-off-by: yamacir-kit <[email protected]>
… of `evaluateSpeed` Signed-off-by: yamacir-kit <[email protected]>
…`evaluateSpeed` Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
Quality Gate passedIssues Measures |
HansRobo
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Added a static member function version of
SpeedCondition::evaluate
.Background
The static version of
SpeedCondition::evaluate
is useful for implementing TimeToCollisionCondition, so we implemented it.Details
None.
References
None.
Destructive Changes
None.
Known Limitations
None.