-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rjd 736/autoware msgs support and localization sim mode support #1484
Merged
yamacir-kit
merged 18 commits into
master
from
RJD-736/autoware_msgs_support_and_localization_sim_mode_support
Dec 16, 2024
Merged
Rjd 736/autoware msgs support and localization sim mode support #1484
yamacir-kit
merged 18 commits into
master
from
RJD-736/autoware_msgs_support_and_localization_sim_mode_support
Dec 16, 2024
+71
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamacir-kit <[email protected]>
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…gs_support_and_localization_sim_mode_support
yamacir-kit
added
feature
New feature or request
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
labels
Dec 11, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…tion_sim_mode_support
…tion_sim_mode_support
…tion_sim_mode_support
…gs_support_and_localization_sim_mode_support Signed-off-by: yamacir-kit <[email protected]>
…gs_support_and_localization_sim_mode_support
…tion.md` Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…tion_sim_mode_support
HansRobo
approved these changes
Dec 16, 2024
Quality Gate passedIssues Measures |
github-actions
bot
deleted the
RJD-736/autoware_msgs_support_and_localization_sim_mode_support
branch
December 16, 2024 05:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Added the option
simulate_localization:=<boolean>
to simulate the optionlocalization_sim_mode:=<api | pose_twist_estimator>
of simple_planning_simulator.Background
Previously, scenario_simulator_v2 also simulated Autoware's localization module, but in order to test the localization module, an option was needed to leave this to Autoware rather than doing it on the scenario_simulator_v2 side.
Feature request thread (internal link)
Details
The default is
simulate_localization:=true
, which performs the same operation aslocalization_sim_mode:=api
. This is compatible with the previous scenario_simulator_v2. On the other hand, whensimulate_localization:=false
, it performs the same operation aslocalization_sim_mode:=pose_twist_estimator
.References
None.
Destructive Changes
None.
Known Limitations
None.