Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjd 736/autoware msgs support and localization sim mode support #1484

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Dec 11, 2024

Description

Abstract

Added the option simulate_localization:=<boolean> to simulate the option localization_sim_mode:=<api | pose_twist_estimator> of simple_planning_simulator.

Background

Previously, scenario_simulator_v2 also simulated Autoware's localization module, but in order to test the localization module, an option was needed to leave this to Autoware rather than doing it on the scenario_simulator_v2 side.

Feature request thread (internal link)

Details

The default is simulate_localization:=true, which performs the same operation as localization_sim_mode:=api. This is compatible with the previous scenario_simulator_v2. On the other hand, when simulate_localization:=false, it performs the same operation as localization_sim_mode:=pose_twist_estimator.

References

None.

Destructive Changes

None.

Known Limitations

None.

…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support

Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…nto RJD-736/autoware_msgs_support_and_localization_sim_mode_support
…gs_support_and_localization_sim_mode_support
@yamacir-kit yamacir-kit added feature New feature or request bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 labels Dec 11, 2024
@yamacir-kit yamacir-kit self-assigned this Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@yamacir-kit yamacir-kit requested a review from HansRobo December 13, 2024 07:05
@yamacir-kit yamacir-kit marked this pull request as ready for review December 13, 2024 07:05
@yamacir-kit yamacir-kit merged commit 72e5d44 into master Dec 16, 2024
14 checks passed
@github-actions github-actions bot deleted the RJD-736/autoware_msgs_support_and_localization_sim_mode_support branch December 16, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants