feat(pandar_description): add pandar_qt128 description #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
commented
Jul 4, 2024
| <color rgba="0.9 0.9 0.9 1.0"/> | ||
| </material> | ||
|
|
||
| <xacro:macro name="PandarQT-128" params="name parent x y z roll pitch yaw"> |
There was a problem hiding this comment.
The naming convention of PandarQT-128 complies with PandarOT-128
TomohitoAndo
commented
Jul 4, 2024
| <origin xyz="0 0.051 0.0144" rpy="1.57 0 0"/> | ||
| <material name="gray_material"/> | ||
| </visual> | ||
| </link> |
There was a problem hiding this comment.
<inertial> has meaningless value currently, and this causes following ERROR. So I removed.
[ERROR 1720051304.540860749] [rviz2]: The link is static or has unrealistic inertia, so the equivalent inertia box will not be shown.
sensor_component_description/pandar_description/urdf/pandar_qt.xacro
Lines 55 to 59 in cf6acf3
TomohitoAndo
commented
Jul 5, 2024
| <!-- LiDAR connector visualization --> | ||
| <visual> | ||
| <geometry> | ||
| <cylinder length="0.015" radius="0.0057"/> |
There was a problem hiding this comment.
The connector is actually ellipse, but simply define as cylinder here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added sensor description of Pandar QT128
Related:
TIER IV INTERNAL
https://www.hesaitech.com/downloads/#qt128
Tests performed