Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_msgs): add acceleration field in VelocityLimitConstraints.msg #154

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

go-sakayori
Copy link
Contributor

Related Links

https://github.com/orgs/autowarefoundation/discussions/5209

Description

This PR adds an acceleration field in the VelocityLimitConstraints.msg, enabling to consider acceleration in packages such as external velocity limiter etc.

Remarks

No regression as checked in TIER IV internal evaluator

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Go Sakayori <[email protected]>
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@go-sakayori
Copy link
Contributor Author

@yukkysaito
I don't have the authority to merge, so can you? Thanks in advance.

@@ -1,3 +1,4 @@
float32 max_acceleration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could you please add a comment here indicating that this is the maximum signed acceleration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 1377eef

Signed-off-by: Go Sakayori <[email protected]>
@yukkysaito yukkysaito merged commit 08da64e into tier4/universe Nov 27, 2024
10 checks passed
@yukkysaito yukkysaito deleted the velocity_limit_constrain_add_acceleration branch November 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants