Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-deterministic cagg_insert isolation test #6030

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

jnidzwetzki
Copy link
Contributor

One permutation of the cagg_insert isolation test contains an assumption about the execution order of three processes after a lock is released. However, this behavior is non-deterministic. This PR makes the assumption explicit and adds proper markers to the isolation test to make the output deterministic.

Disable-check: force-changelog-file

One permutation of the cagg_insert isolation test contains an assumption
about the execution order of three processes after a lock is released.
However, this behavior is non-deterministic. This PR makes the
assumption explicit and adds proper markers to the isolation test to
make the output deterministic.
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #6030 (9275669) into main (3b6dc7d) will decrease coverage by 5.93%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6030      +/-   ##
==========================================
- Coverage   87.14%   81.21%   -5.93%     
==========================================
  Files         243      243              
  Lines       55969    55925      -44     
  Branches    12397    12378      -19     
==========================================
- Hits        48775    45421    -3354     
- Misses       4856     8169    +3313     
+ Partials     2338     2335       -3     

see 94 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jnidzwetzki jnidzwetzki marked this pull request as ready for review August 31, 2023 08:24
@github-actions
Copy link

@shhnwz, @mahipv: please review this pull request.

Powered by pull-review

@github-actions github-actions bot requested review from mahipv and shhnwz August 31, 2023 08:25
@jnidzwetzki jnidzwetzki enabled auto-merge (rebase) August 31, 2023 08:56
@jnidzwetzki jnidzwetzki merged commit 77dc6ed into timescale:main Aug 31, 2023
38 checks passed
@timescale-automation
Copy link

Automated backport to 2.11.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.11.x
You are currently cherry-picking commit 77dc6ed42.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tsl/test/isolation/specs/cagg_insert.spec

no changes added to commit (use "git add" and/or "git commit -a")

Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants