Improve arg handling in continuous_agg_trigfn #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When continuous_agg_invalidation_trigger is called without any argument, fcinfo->context in continuous_agg_trigfn is NULL and it should not be dereferenced.
|
@fabriziomello, @nikkhils: please review this pull request.
|
svenklemm
approved these changes
Oct 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #6160 +/- ##
==========================================
- Coverage 81.44% 73.81% -7.64%
==========================================
Files 246 246
Lines 56974 49818 -7156
Branches 12624 12503 -121
==========================================
- Hits 46402 36771 -9631
+ Misses 8192 7217 -975
- Partials 2380 5830 +3450
... and 226 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fabriziomello
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
continuous_agg_invalidation_triggeris called without any argument, fcinfo->context in continuous_agg_trigfn is NULL and it should not be dereferenced.Disable-check: force-changelog-file