Adjust restore points test for PG 16 #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, MN is not supported on PG16. Therefore, the creation of distributed restore points fails on PG16. This patch disables the CI test for this PG version.
jnidzwetzki
force-pushed
the
additional_tests_workflow
branch
from
3976221 to
4bc82d7
Compare
jnidzwetzki
commented
Nov 9, 2023
| @@ -297,6 +297,11 @@ if [ ${PG_VERSION_MAJOR} -lt 13 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if [ ${PG_VERSION_MAJOR} -ge 16 ]; then | |||
There was a problem hiding this comment.
The check is performed in the shell script and not excluded from the build matrix in the workflow since matrix exclusion would require the exact PG version and needs to be adjusted with every version upgrade.
exclude:
- pg: "16.0"
Here, we can perform the test based on the PG major version.
|
@antekresic, @erimatnor: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #6298 +/- ##
==========================================
- Coverage 65.44% 65.37% -0.07%
==========================================
Files 247 247
Lines 57663 57637 -26
Branches 12819 12809 -10
==========================================
- Hits 37736 37679 -57
- Misses 18087 18109 +22
- Partials 1840 1849 +9 see 23 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
akuzm
approved these changes
Nov 9, 2023
konskov
reviewed
Nov 9, 2023
| @@ -4,6 +4,8 @@ name: Additional tests | |||
| branches: | |||
| - main | |||
| - prerelease_test | |||
| - trigger/additional_tests | |||
konskov
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MN is not supported on PG16. Therefore, the creation of distributed restore points fails on PG16. This patch disables the CI test for this PG version.
Disable-check: force-changelog-file
Link to broken CI run: https://github.com/timescale/timescaledb/actions/runs/6808663440/job/18513494748
Link to fixed CI run: https://github.com/timescale/timescaledb/actions/runs/6809128223/job/18514813987?pr=6298