Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate runner output cleanup into single script #7511

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Dec 3, 2024

Disable-check: force-changelog-file

@fabriziomello fabriziomello added testing tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" labels Dec 3, 2024
@fabriziomello fabriziomello self-assigned this Dec 3, 2024
@fabriziomello fabriziomello force-pushed the encapsulate_runner_output_cleanup_into_single_script branch from 5232f76 to 158f3ac Compare December 3, 2024 00:10
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull request Dec 3, 2024
Filter the runner output to replace `Heap Fetches: [0-9]` to a
predictable value to avoid flaky output test.

It depends on timescale#7511.
@fabriziomello fabriziomello force-pushed the encapsulate_runner_output_cleanup_into_single_script branch from 158f3ac to a6ca45d Compare December 3, 2024 00:35
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull request Dec 3, 2024
Filter the runner output to replace `Heap Fetches: [0-9]` to a
predictable value to avoid flaky output test.

It depends on timescale#7511.
@fabriziomello fabriziomello force-pushed the encapsulate_runner_output_cleanup_into_single_script branch from a6ca45d to 857270c Compare December 3, 2024 12:49
@fabriziomello fabriziomello enabled auto-merge (rebase) December 3, 2024 12:49
@fabriziomello fabriziomello force-pushed the encapsulate_runner_output_cleanup_into_single_script branch from 857270c to 44eebd7 Compare December 3, 2024 14:17
@fabriziomello fabriziomello force-pushed the encapsulate_runner_output_cleanup_into_single_script branch from 44eebd7 to 8607998 Compare December 3, 2024 14:26
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.15%. Comparing base (59f50f2) to head (8607998).
Report is 638 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7511      +/-   ##
==========================================
+ Coverage   80.06%   82.15%   +2.08%     
==========================================
  Files         190      230      +40     
  Lines       37181    43191    +6010     
  Branches     9450    10869    +1419     
==========================================
+ Hits        29770    35484    +5714     
- Misses       2997     3383     +386     
+ Partials     4414     4324      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello merged commit 049714c into timescale:main Dec 3, 2024
45 checks passed
@timescale-automation
Copy link

Automated backport to 2.17.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.17.x
You are currently cherry-picking commit 049714cde.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   test/runner_cleanup_output.sh
	modified:   test/runner_isolation.sh
	modified:   test/runner_shared.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/runner.sh


Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Dec 3, 2024
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull request Dec 3, 2024
Filter the runner output to replace `Heap Fetches: [0-9]` to a
predictable value to avoid flaky output test.

It depends on timescale#7511.
fabriziomello added a commit to fabriziomello/timescaledb that referenced this pull request Dec 3, 2024
Filter the runner output to replace `Heap Fetches: [0-9]` to a
predictable value to avoid flaky output test.

It depends on timescale#7511.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants