device/arm: clear pending interrupts before enabling them #4849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasnaur
force-pushed
the
push-vxtmoymmrkwp
branch
from
a28c4f1 to
9aed2b0
Compare
Without this change, a pending interrupt would spuriously trigger immediately after enabling. This happens if an interrupt is triggered during flashing (e.g. by DMA), which survives the subsequent reset. This behaviour matches e.g. `machine.irqSet` in machine_rp2_rp2350.go. See 7f970a4, whose symptoms were likely caused by spurious interrupts.
eliasnaur
force-pushed
the
push-vxtmoymmrkwp
branch
from
9aed2b0 to
bc6a0a5
Compare
soypat
approved these changes
Apr 15, 2025
|
Now merging, thanks for working on this @eliasnaur and to @soypat for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, a pending interrupt would spuriously trigger immediately after enabling. This happens if an interrupt is triggered during flashing (e.g. by DMA), which survives the subsequent reset.
This behaviour matches e.g.
machine.irqSetin machine_rp2_rp2350.go.See 7f970a4, whose symptoms were likely caused by spurious interrupts.