Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add missing in-app shortcuts in new settings #352

Closed
Tracked by #374 ...
tisfeng opened this issue Jan 22, 2024 · 11 comments
Closed
Tracked by #374 ...

dev: Add missing in-app shortcuts in new settings #352

tisfeng opened this issue Jan 22, 2024 · 11 comments
Assignees

Comments

@tisfeng
Copy link
Owner

tisfeng commented Jan 22, 2024

It seems that when using the new EasydictApp.swift to launch, the shortcuts in the previous Main.storyboard are not loaded, and shortcuts like Cmd+P for pinning the window do not work.

In addition, we can also move these in-app shortcuts to the new shortcut tab and allow users to modify them.

image
@tisfeng
Copy link
Owner Author

tisfeng commented Feb 4, 2024

How is this going, can we add it in the next few days?

I hope to release a new version before Chinese New Year.

@AkaShark
Copy link
Collaborator

AkaShark commented Feb 4, 2024

yeah, I will PR soon, I'll try to make it later today or tomorrow

@AkaShark
Copy link
Collaborator

AkaShark commented Feb 4, 2024

It seems that when using the new EasydictApp.swift to launch, the shortcuts in the previous Main.storyboard are not loaded, and shortcuts like Cmd+P for pinning the window do not work.

SwiftUI seem not support storyboar, I will add shortcut commands in this term. For other parts, should we add a new issues to track.

@tisfeng
Copy link
Owner Author

tisfeng commented Feb 4, 2024

For other parts, should we add a new issues to track.

What exactly does this mean? Is there any problem?

@tisfeng
Copy link
Owner Author

tisfeng commented Feb 4, 2024

If you feel like this issue is a little big, we could do it in two steps. This time we just add all the in-app shortcuts, that is the most important thing.

We can support custom shortcuts in another issue later.

@tisfeng
Copy link
Owner Author

tisfeng commented Feb 4, 2024

Even this shortcuts menu UI is not necessary, we can put it off and do it later.

@AkaShark
Copy link
Collaborator

AkaShark commented Feb 4, 2024

yeah, I mean using SwiftUI in EasydictApp.swift to launch is not support setting UI by storyboard(Main.storyboard). You can see this in new app is different with Main.storyboard
CleanShot 2024-02-04 at 23 17 52@2x
CleanShot 2024-02-04 at 23 19 05@2x
So, I think in this issues we need finished shortcut and open other issues to track other menu like file, format,etc

@AkaShark
Copy link
Collaborator

AkaShark commented Feb 4, 2024

Even this shortcuts menu UI is not necessary, we can put it off and do it later.

It's okay, I'm almost done the shortcut part

@tisfeng
Copy link
Owner Author

tisfeng commented Feb 4, 2024

The new settings will not invoke Main.storyboard, we don't need to care about it.

If we need to add new menu items in the future, we can use Swift/SwiftUI code.

@AkaShark
Copy link
Collaborator

AkaShark commented Feb 4, 2024

The new settings will not invoke Main.storyboard, we don't need to care about it.

If we need to add new menu items in the future, we can use Swift/SwiftUI code.

yeah, if we need to track other menu items, I suggest opening another issue instead of finishing this one.

@tisfeng
Copy link
Owner Author

tisfeng commented Feb 4, 2024

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants