-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: Add missing in-app shortcuts in new settings #352
Comments
How is this going, can we add it in the next few days? I hope to release a new version before Chinese New Year. |
yeah, I will PR soon, I'll try to make it later today or tomorrow |
SwiftUI seem not support storyboar, I will add shortcut commands in this term. For other parts, should we add a new issues to track. |
What exactly does this mean? Is there any problem? |
If you feel like this issue is a little big, we could do it in two steps. This time we just add all the in-app shortcuts, that is the most important thing. We can support custom shortcuts in another issue later. |
Even this shortcuts menu UI is not necessary, we can put it off and do it later. |
It's okay, I'm almost done the shortcut part |
The new settings will not invoke Main.storyboard, we don't need to care about it. If we need to add new menu items in the future, we can use Swift/SwiftUI code. |
yeah, if we need to track other menu items, I suggest opening another issue instead of finishing this one. |
ok |
It seems that when using the new
EasydictApp.swift
to launch, the shortcuts in the previousMain.storyboard
are not loaded, and shortcuts likeCmd+P
for pinning the window do not work.In addition, we can also move these in-app shortcuts to the new shortcut tab and allow users to modify them.
The text was updated successfully, but these errors were encountered: